VectorMap: support mixed geometry types in GeoJSON (T1327745)#33477
Merged
pharret31 merged 1 commit intoDevExpress:26_1from Apr 30, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the VectorMap layer projection logic to correctly handle GeoJSON line layers that contain a mix of LineString and MultiLineString geometries (T1327745), preventing incorrect projection results when the first feature’s geometry differs from subsequent features.
Changes:
- Reworked line projection selection to be adaptive per feature, using the feature’s GeoJSON
geometry.typewhen available. - Adjusted/extended VectorMap QUnit tests to cover mixed
LineString/MultiLineStringGeoJSON feature collections. - Updated expectations for degenerate
MultiLineStringprojection output to match the new adaptive behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.viz.vectorMap/mapLayer_new.tests.js |
Adds coverage for mixed LineString/MultiLineString GeoJSON in line layers and updates degenerate output expectation. |
packages/devextreme/testing/tests/DevExpress.viz.vectorMap/mapLayer.strategies.tests.js |
Updates strategy projection tests to pass explicit geometry type into the line projection logic. |
packages/devextreme/js/__internal/viz/vector_map/map_layer.ts |
Implements per-element adaptive line projection and passes GeoJSON geometry.type into projection. |
pharret31
force-pushed
the
26_1_4070-t1327745---vectormap---mixed-geometry-types-in-geojson-are-not-supported
branch
from
6ff49ff to
b87db0e
Compare
dmlvr
approved these changes
Apr 30, 2026
pharret31
deleted the
26_1_4070-t1327745---vectormap---mixed-geometry-types-in-geojson-are-not-supported
branch
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.